Skip to content

Added charm config #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Apr 4, 2025
Merged

Added charm config #117

merged 52 commits into from
Apr 4, 2025

Conversation

@samhotep
Copy link
Member

@samhotep samhotep commented Jan 28, 2025 •
edited by atlassian bot
Loading

Done

  • Added charm config for building a cs.canonical.com charm. This config should not affect current deployments, but allow deploying as both a plain kubernetes resource or as a charm.

QA

QA steps

  • Run the project locally, following the README.md and confirm that there are no issues.

Fixes WD-19933

@webteam-app
Copy link

Demo

Jenkins

demos.haus

akbarkz
akbarkz reviewed Jan 31, 2025
View reviewed changes
samhotep
samhotep commented Jan 31, 2025
View reviewed changes
@samhotep samhotep force-pushed the add-charm branch 2 times, most recently from 57a27aa to fd72c40 Compare March 5, 2025 09:11
@samhotep samhotep changed the title wip: added charm config Added charm config Mar 5, 2025
muhammad-ali-pk
muhammad-ali-pk reviewed Mar 5, 2025
View reviewed changes
@samhotep samhotep merged commit b71af05 into main Apr 4, 2025
10 of 12 checks passed
@samhotep samhotep deleted the add-charm branch April 4, 2025 08:21
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akbarkz akbarkz akbarkz left review comments

@muhammad-ali-pk muhammad-ali-pk muhammad-ali-pk left review comments

Assignees

No one assigned

Labels

released Review: Code Needed Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samhotep @webteam-app @akbarkz @muhammad-ali-pk